Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed extensions (tokenizers) loading on Android #26437

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Fixed extensions (tokenizers) loading on Android #26437

merged 1 commit into from
Sep 5, 2024

Conversation

ilya-lavrenov
Copy link
Contributor

Details:

  • Android 's clang has issues with RTTI. So, we need to expose virtual methods from the class to ensure dynamic cast is working.

@ilya-lavrenov ilya-lavrenov requested a review from a team as a code owner September 5, 2024 08:03
@ilya-lavrenov ilya-lavrenov mentioned this pull request Sep 5, 2024
Merged
@github-actions github-actions bot added category: Core OpenVINO Core (aka ngraph) category: CPP API OpenVINO CPP API bindings labels Sep 5, 2024
@ilya-lavrenov ilya-lavrenov added this to the 2024.4 milestone Sep 5, 2024
ilya-lavrenov added a commit that referenced this pull request Sep 5, 2024
@ilya-lavrenov
Fixed extensions (tokenizers) loading on Android (#26436)
e2cfe28 
### Details:
 - Ported #26437
@ilya-lavrenov ilya-lavrenov added this pull request to the merge queue Sep 5, 2024
Merged via the queue into openvinotoolkit:releases/2024/4 with commit e320367 Sep 5, 2024
146 checks passed
@ilya-lavrenov ilya-lavrenov deleted the android-extensions branch September 5, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barnasm1 barnasm1 barnasm1 approved these changes

@t-jankowski t-jankowski t-jankowski approved these changes

@apaniukov apaniukov apaniukov approved these changes

@olpipi olpipi olpipi approved these changes

Assignees

@apaniukov apaniukov

Labels
category: Core OpenVINO Core (aka ngraph) category: CPP API OpenVINO CPP API bindings Code Freeze
Projects
None yet
Milestone
2024.4
Development

Successfully merging this pull request may close these issues.
5 participants
@ilya-lavrenov @olpipi @apaniukov @t-jankowski @barnasm1